-
Notifications
You must be signed in to change notification settings - Fork 37
feat: Enable to use defaultDagBuilder with custom builders #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Please can you:
- Revert the formatting changes
- Add some tests to ensure there are no regressions in future
I pushed the requested changes lmk if I can furtherly help |
Any news on this one? |
achingbrain
approved these changes
Jun 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
## [ipfs-unixfs-importer-v15.4.0](ipfs-unixfs-importer-15.3.4...ipfs-unixfs-importer-15.4.0) (2025-06-18) ### Features * enable custom file/directory builders ([#413](#413)) ([d06d9fe](d06d9fe))
🎉 This PR is included in version ipfs-unixfs-importer-v15.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add some additional optional metadata to directory's IPLD objects having an almost equal IPLD object as the IPFS standard. For this reason, we would want to use the
defaultDagBuilder
but customising just how file and directories IPLD objects are formed.For achieving this I added two additional fields to
DagBuilderOptions
&ImporterOptions
that would override thedirBuilder
&fileBuilder
if that option is provided.